[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs nee
From: |
David Ahern |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files |
Date: |
Fri, 14 Jan 2011 14:54:07 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 01/14/11 14:36, Blue Swirl wrote:
> On Fri, Jan 14, 2011 at 9:04 PM, David Ahern <address@hidden> wrote:
>>
>>
>> On 01/14/11 13:57, Blue Swirl wrote:
>>>>> That's OK, but the correct fix is to change the design of the machine
>>>>> model to something more advanced where the unwanted objects are simply
>>>>> not linked in, without any changes to board code. This is not so
>>>>> trivial and also many devices are not architecturally clean yet.
>>>>
>>>> A lot of changes are need to obtain that goal, and I am not the right
>>>> person to do them. Until that ideal design can be developed and
>>>> implemented why not take a small patch that fixes the existing design?
>>>> It's not a major change -- a very small one actually (4 files, 13 lines
>>>> modified).
>>>
>>> So far the approach has been to make changes only in line with that goal.
>>
>> That's a shame.
>>
>> I'll collapse the patch series and maintain it locally then.
>
> Patches 1, 5, 10, and 11 still look fine to me.
Fine by me. The more you take, the less I have to carry locally.
Sounds like patch 1 should be Stefan's patch since it pre-dates what I sent.
David
- Re: [Qemu-devel] [PATCH 01/11] fix 'no such file' error from make_device_config.sh, (continued)
- [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, David Ahern, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, Blue Swirl, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, David Ahern, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, Blue Swirl, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, David Ahern, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, Blue Swirl, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, David Ahern, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files, Blue Swirl, 2011/01/14
- Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files,
David Ahern <=
- [Qemu-devel] Re: [PATCH 02/11] config: settings from default-configs need to be included in header files, Paolo Bonzini, 2011/01/15
- [Qemu-devel] Re: [PATCH 02/11] config: settings from default-configs need to be included in header files, Blue Swirl, 2011/01/15
[Qemu-devel] [PATCH 03/11] config: fix compile for CONFIG_VMWARE_VGA=n, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 04/11] config: fix compile for CONFIG_PARALLEL=n, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 06/11] config: fix compile for CONFIG_NE2000_ISA=n, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 05/11] remove unused parallel_* variables from pc.c, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 07/11] config: handle CONFIG_VGA_ISA=n, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 08/11] config: fix compile for CONFIG_IDE_ISA=n, David Ahern, 2011/01/14
[Qemu-devel] [PATCH 09/11] config: fix compile for CONFIG_FDC=n, David Ahern, 2011/01/14