Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

[Christoph Hellwig]

On Mon, Jan 17, 2011 at 10:04:05AM +0000, Stefan Hajnoczi wrote:
> I was considering not using bdrv_set_removable() and instead adding a
> hint to the BlockDriverState which gets checked when constructing the
> SCSI INQUIRY response.  If we take that approach, then QEMU doesn't
> consider the block device removable in the eject/change medium sense.

I think that's the better approach.  What about moving the removable
qdev property up from the usb driver into the scsi-disk driver?  That's
where it logically belongs, and avoids the need to add another hint.