[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices |
Date: |
Tue, 18 Jan 2011 13:48:06 +0100 |
User-agent: |
Mutt/1.3.28i |
On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote:
> Well, what happens is this: we screwed up with that interface and we
> should replace it soon.
>
> I see you're not adding the new command in QMP (only in the human monitor),
> is that intentional? (qmp commands are added to the qmp-commands.hx file).
>
> If it's intentional, then using only error_report() should be ok. If you
> plan to have a qmp version, then we'll have to choose between reporting
> a generic error version to the client, which is what's going to happen if
> you use error_report(), or add the QERR_ macros.
No, I hoped this would also add the QMP interface. Why do we need to
declare the commands twice? Especially as hmp-commands.hx is full of
magic that makes little sense only for human readable commands.
Any help on how to define the QERR_ macros?
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, (continued)
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize, Christoph Hellwig, 2011/01/14
[Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes, Christoph Hellwig, 2011/01/14
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices, Luiz Capitulino, 2011/01/18
- Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices,
Christoph Hellwig <=