[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/23] Avoid divide by zero when there is no block d
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 05/23] Avoid divide by zero when there is no block device to migrate |
Date: |
Mon, 24 Jan 2011 22:10:34 +0100 |
From: Pierre Riteau <address@hidden>
When block migration is requested and no read-write block device is
present, a divide by zero exception is triggered because
total_sector_sum equals zero.
Signed-off-by: Pierre Riteau <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block-migration.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 1475325..60b9fc0 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -350,7 +350,12 @@ static int blk_mig_save_bulked_block(Monitor *mon,
QEMUFile *f)
}
}
- progress = completed_sector_sum * 100 / block_mig_state.total_sector_sum;
+ if (block_mig_state.total_sector_sum != 0) {
+ progress = completed_sector_sum * 100 /
+ block_mig_state.total_sector_sum;
+ } else {
+ progress = 100;
+ }
if (progress != block_mig_state.prev_progress) {
block_mig_state.prev_progress = progress;
qemu_put_be64(f, (progress << BDRV_SECTOR_BITS)
--
1.7.2.3
- [Qemu-devel] [PULL 00/23] Block patches, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 01/23] qcow2: fix unaligned access, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 02/23] qemu-img snapshot: Use writeback caching, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 03/23] do_snapshot_blkdev() error on missing snapshot_file argument, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 04/23] Make strtosz() return int64_t instead of ssize_t, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 05/23] Avoid divide by zero when there is no block device to migrate,
Kevin Wolf <=
- [Qemu-devel] [PATCH 06/23] ide: factor dma handling helpers, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 07/23] ide: also reset io_buffer_index for writes, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 08/23] ide: kill ide_dma_submit_check, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 09/23] qcow2: Add QcowCache, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 11/23] qcow2: Batch flushes for COW, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 10/23] qcow2: Use QcowCache, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 13/23] Documentation: Add qemu-img check/rebase, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 14/23] qed: Refuse to create images on block devices, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 15/23] Fix block migration when the device size is not a multiple of 1 MB, Kevin Wolf, 2011/01/24