[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] prep: Remove bogus BIOS size check
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] prep: Remove bogus BIOS size check |
Date: |
Sat, 29 Jan 2011 16:03:42 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Jan 18, 2011 at 10:43:55PM +0100, Hervé Poussineau wrote:
> From: Andreas Färber <address@hidden>
>
> r3480 added this check to account for the entry vector 0xfff00100 to be
> available for CPUs that need it. Today however, the NIP is not yet
> initialized at this point (zero), so the check always triggers.
>
> Moreover, BIOS size check is already done previously, so this part can
> be removed too.
>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/ppc_prep.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
Thanks, applied.
> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index 1492266..6b22122 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -600,9 +600,6 @@ static void ppc_prep_init (ram_addr_t ram_size,
> if (filename) {
> qemu_free(filename);
> }
> - if (env->nip < 0xFFF80000 && bios_size < 0x00100000) {
> - hw_error("PowerPC 601 / 620 / 970 need a 1MB BIOS\n");
> - }
>
> if (linux_boot) {
> kernel_base = KERNEL_LOAD_ADDR;
> --
> 1.7.2.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net