[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device |
Date: |
Sun, 30 Jan 2011 19:35:01 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote:
> On 01/11/2011 02:42 AM, Alon Levy wrote:
> >diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h
> >new file mode 100644
> >index 0000000..9ff1295
> >--- /dev/null
> >+++ b/libcacard/vscard_common.h
>
> This file (and the .c file) need a coding style pass to fixup
> comments and the use of _ as a prefix but I want to focus on the
> protocol itself.
>
> First, let's get a written spec into the wiki. I think it's
> important that all of our compatibility protocols are documented in
> a more formal way such that can be reviewed by a wider audience.
http://wiki.qeum.org/Features/Smartcard
I'm still working on the rest, but you can review and comment on it. I've
done a number of changes from the submitted here. I guess the idea is that
iterations on the wiki can be faster? The changes done to the protocol:
Removed Reconnect - doesn't scale easily, the same work should be done
by whomever is initiating the migration, or via other mechanisms (i.e.
spice)
Added Flush/FlushComplete - still need to be able to tell client to wrap
up the outstanding operations in any way. I'm planning on implementing
this using register_savevm_live.
Fixes suggested by you - set the enum, removed _ from surrounding #ifdef
(btw - why does no one use #pragma once? IIUC it's supported by gcc?)
The major issue I haven't tackled yet is the thread removal in
ccid-card-emulated.c
is that a blocker for integration? Can it be tackled later?
Alon
[snip]
[Qemu-devel] [PATCH 7/7] ccid: add qdev description strings, Alon Levy, 2011/01/11
[Qemu-devel] [PATCH 6/7] ccid: configure: add --enable/disable and nss only disable, Alon Levy, 2011/01/11
[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus, Alon Levy, 2011/01/11
[Qemu-devel] [PATCH 3/7] libcacard: initial commit after coding style fixes, Alon Levy, 2011/01/11
Re: [Qemu-devel] [PATCH 0/7] usb-ccid (v15), Alon Levy, 2011/01/17