[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 01/22] Prevent abortion on multiple VCPU kicks
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 01/22] Prevent abortion on multiple VCPU kicks |
Date: |
Mon, 31 Jan 2011 12:19:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-01-31 10:44, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If we call qemu_cpu_kick more than once before the target was able to
>> process the signal, pthread_kill will fail, and qemu will abort. Prevent
>> this by avoiding the redundant signal.
>>
>
> Doesn't fit with the manual page (or with the idea that signals are
> asynchronous):
>
> NAME
> pthread_kill - send a signal to a thread
>
>
> ...
>
> ERRORS
> ESRCH No thread with the ID thread could be found.
>
> EINVAL An invalid signal was specified.
>
Valid remark, but I was receiving EAGAIN for blocked RT signals. Don't
know if this is Linux-specific. A quick glance at the man pages did not
reveal if this is allowed or at least gray area.
However, even when selectively ignoring this, it's more efficient to
catch the redundant signaling in user space.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH 06/22] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn, (continued)
- [Qemu-devel] [PATCH 06/22] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 13/22] Set up signalfd under !CONFIG_IOTHREAD, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 16/22] Introduce VCPU self-signaling service, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 02/22] Stop current VCPU on synchronous reset requests, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 08/22] kvm: Provide sigbus services arch-independently, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 01/22] Prevent abortion on multiple VCPU kicks, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 09/22] Refactor signal setup functions in cpus.c, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 20/22] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 22/22] Fix a few coding style violations in cpus.c, Jan Kiszka, 2011/01/27
- [Qemu-devel] [PATCH 17/22] kvm: Move irqchip event processing out of inner loop, Jan Kiszka, 2011/01/27