Re: [Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

[Peter Maydell]

On 24 January 2011 12:41, Christophe Lyon <address@hidden> wrote:
> Here is an updated patch with these minor fixes.

> +uint64_t HELPER(neon_qadd_u64)(CPUState *env, uint64_t src1, uint64_t src2)
> +{
> +  uint64_t res;
> +
> +  res = src1 + src2;
> +  if (res < src1) {
> +    SET_QC();
> +    res = ~(uint64_t)0;
> +  }
> +  return res;
> +}

Indentation is still wrong here (not sure why checkpatch didn't
spot it) and in the other s64 and u64 helpers. Sorry I didn't
notice that last time round.

When you resubmit v3 can you make sure you use the right
email format to give a sensible git commit message, please?
(ie random commentary below the '---' so it doesn't go in
the git changelog.)

Thanks
-- PMM