[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/10] target-arm: fix decoding of Neon 64 bit shift
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 07/10] target-arm: fix decoding of Neon 64 bit shifts. |
Date: |
Tue, 15 Feb 2011 13:44:47 +0000 |
From: Christophe Lyon <address@hidden>
Fix decoding of 64 bits variants of VSHRN, VRSHRN, VQSHRN, VQSHRUN,
VQRSHRN, VQRSHRUN, taking into account whether inputs are unsigned
or not.
Signed-off-by: Christophe Lyon <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
target-arm/translate.c | 45 ++++++++++++++++++++++++++++++---------------
1 files changed, 30 insertions(+), 15 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index bd26b1b..a02b20f 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -4815,6 +4815,8 @@ static int disas_neon_data_insn(CPUState * env,
DisasContext *s, uint32_t insn)
} else if (op < 10) {
/* Shift by immediate and narrow:
VSHRN, VRSHRN, VQSHRN, VQRSHRN. */
+ int input_unsigned = (op == 8) ? !u : u;
+
shift = shift - (1 << (size + 3));
size++;
switch (size) {
@@ -4841,33 +4843,46 @@ static int disas_neon_data_insn(CPUState * env,
DisasContext *s, uint32_t insn)
if (size == 3) {
neon_load_reg64(cpu_V0, rm + pass);
if (q) {
- if (u)
- gen_helper_neon_rshl_u64(cpu_V0, cpu_V0, tmp64);
- else
- gen_helper_neon_rshl_s64(cpu_V0, cpu_V0, tmp64);
+ if (input_unsigned) {
+ gen_helper_neon_rshl_u64(cpu_V0, cpu_V0,
+ tmp64);
+ } else {
+ gen_helper_neon_rshl_s64(cpu_V0, cpu_V0,
+ tmp64);
+ }
} else {
- if (u)
- gen_helper_neon_shl_u64(cpu_V0, cpu_V0, tmp64);
- else
- gen_helper_neon_shl_s64(cpu_V0, cpu_V0, tmp64);
+ if (input_unsigned) {
+ gen_helper_neon_shl_u64(cpu_V0, cpu_V0,
+ tmp64);
+ } else {
+ gen_helper_neon_shl_s64(cpu_V0, cpu_V0,
+ tmp64);
+ }
}
} else {
tmp = neon_load_reg(rm + pass, 0);
- gen_neon_shift_narrow(size, tmp, tmp2, q, u);
+ gen_neon_shift_narrow(size, tmp, tmp2, q,
+ input_unsigned);
tmp3 = neon_load_reg(rm + pass, 1);
- gen_neon_shift_narrow(size, tmp3, tmp2, q, u);
+ gen_neon_shift_narrow(size, tmp3, tmp2, q,
+ input_unsigned);
tcg_gen_concat_i32_i64(cpu_V0, tmp, tmp3);
dead_tmp(tmp);
dead_tmp(tmp3);
}
tmp = new_tmp();
- if (op == 8 && !u) {
- gen_neon_narrow(size - 1, tmp, cpu_V0);
+ if (op == 8) {
+ if (u) { /* VQSHRUN / VQRSHRUN */
+ gen_neon_unarrow_sats(size - 1, tmp, cpu_V0);
+ } else { /* VSHRN / VRSHRN */
+ gen_neon_narrow(size - 1, tmp, cpu_V0);
+ }
} else {
- if (op == 8)
- gen_neon_narrow_sats(size - 1, tmp, cpu_V0);
- else
+ if (u) { /* VQSHRN / VQRSHRN */
gen_neon_narrow_satu(size - 1, tmp, cpu_V0);
+ } else { /* VQSHRN / VQRSHRN */
+ gen_neon_narrow_sats(size - 1, tmp, cpu_V0);
+ }
}
neon_store_reg(rd, pass, tmp);
} /* for pass */
--
1.7.1
- [Qemu-devel] [PATCH 00/10] Fix Neon shift instructions, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 03/10] target-arm: Fix unsigned VRSHL.s8 and .s16 right shifts by type width, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 10/10] target-arm: Fix shift by immediate and narrow where src, dest overlap, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 08/10] target-arm: Fix signed VQRSHL by large shift counts, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 04/10] target-arm: fix unsigned 64 bit right shifts., Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 07/10] target-arm: fix decoding of Neon 64 bit shifts.,
Peter Maydell <=
- [Qemu-devel] [PATCH 05/10] target-arm: Fix saturated values for Neon right shifts, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 02/10] target-arm: Fix signed VRSHL by large shift counts, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 01/10] target-arm: Fix rounding constant addition for Neon shifts, Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 06/10] target-arm: fix Neon VQSHRN and VSHRN., Peter Maydell, 2011/02/15
- [Qemu-devel] [PATCH 09/10] target-arm: Fix unsigned VQRSHL by large shift counts, Peter Maydell, 2011/02/15
- [Qemu-devel] Re: [PATCH 00/10] Fix Neon shift instructions, Christophe Lyon, 2011/02/15
- Re: [Qemu-devel] [PATCH 00/10] Fix Neon shift instructions, Aurelien Jarno, 2011/02/20