|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode |
Date: | Wed, 16 Feb 2011 14:16:28 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 |
On 02/16/2011 01:48 PM, Stefan Weil wrote:
Reverse mode is unusable: qemu -vnc localhost:5500,reverse crashes in vnc_refresh_server_surface because some pointers are NULL. Fix this by calling vnc_dpy_resize (which initializes these pointers) before calling vnc_refresh. Cc: Anthony Liguori<address@hidden> Signed-off-by: Stefan Weil<address@hidden>
Nice catch! Regards, Anthony Liguori
--- ui/vnc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index da83adf..096b5f3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd) vd->timer_interval = VNC_REFRESH_INTERVAL_BASE; if (vd->timer == NULL&& !QTAILQ_EMPTY(&vd->clients)) { vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd); + vnc_dpy_resize(vd->ds); vnc_refresh(vd); } }
[Prev in Thread] | Current Thread | [Next in Thread] |