[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support |
Date: |
Thu, 17 Feb 2011 13:04:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 15.02.2011 17:27, schrieb Michael S. Tsirkin:
> e1000 supports multi-buffer packets larger than rxbuf_size.
>
> This fixes the following (on linux):
> - in guest: ifconfig eth1 mtu 16110
> - in host: ifconfig tap0 mtu 16110
> ping -s 16082 <guest-ip>
>
> Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205
>
> Changes from v1:
> fix buffer overflow reported by Kevin
> added a patch to fix EOP spec violation reported by Juan
> added a patch to fix spec violation noted by myself
>
>
> Michael S. Tsirkin (3):
> e1000: multi-buffer packet support
> e1000: clear EOP for multi-buffer descriptors
> e1000: verify we have buffers, upfront
>
> hw/e1000.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++------------
> 1 files changed, 48 insertions(+), 13 deletions(-)
I found patch 3 to be not that easy to understand (especially the
s->check_rxov part), but after thinking a while about it, it seems to
make sense.
Acked-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCHv2 0/3] e1000: multi-buffer packet support, Michael S. Tsirkin, 2011/02/15
- [Qemu-devel] [PATCHv2 1/3] e1000: multi-buffer packet support, Michael S. Tsirkin, 2011/02/15
- [Qemu-devel] [PATCHv2 2/3] e1000: clear EOP for multi-buffer descriptors, Michael S. Tsirkin, 2011/02/15
- [Qemu-devel] [PATCHv2 3/3] e1000: verify we have buffers, upfront, Michael S. Tsirkin, 2011/02/15
- [Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support, Stefan Hajnoczi, 2011/02/16
- Re: [Qemu-devel] [PATCHv2 0/3] e1000: multi-buffer packet support, Alex Williamson, 2011/02/16
- [Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCHv2 0/3] e1000: multi-buffer packet support, Aurelien Jarno, 2011/02/20