qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2] Fix obvious mistake in pxa2xx i2s driver


From: Vasily Khoruzhick
Subject: [Qemu-devel] [PATCH v2] Fix obvious mistake in pxa2xx i2s driver
Date: Sun, 20 Feb 2011 21:23:59 +0200

RST bit is (1 << 4) bit, not (1 << 3), fix condition
that enables i2s if ENB is set and RST is not set.

Signed-off-by: Vasily Khoruzhick <address@hidden>
---
v2: simplify expression

 hw/pxa2xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c
index d966846..6e41fc6 100644
--- a/hw/pxa2xx.c
+++ b/hw/pxa2xx.c
@@ -1631,7 +1631,7 @@ static void pxa2xx_i2s_write(void *opaque, 
target_phys_addr_t addr,
         }
         if (value & (1 << 4))                          /* EFWR */
             printf("%s: Attempt to use special function\n", __FUNCTION__);
-        s->enable = ((value ^ 4) & 5) == 5;            /* ENB && !RST*/
+        s->enable = (value & 9) == 1;                  /* ENB && !RST*/
         pxa2xx_i2s_update(s);
         break;
     case SACR1:
-- 
1.7.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]