Re: [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless

[Peter Maydell]

On 4 February 2011 08:05, Corentin Chary <address@hidden> wrote:
> Use the new update frequency infrastructure to use jpeg for regions with
> high update frequency.
>
> Signed-off-by: Corentin Chary <address@hidden>

> @@ -1514,6 +1536,8 @@ static int send_sub_rect(VncState *vs, int x, int y, 
> int w, int h)
>     uint32_t bg = 0, fg = 0;
>     int colors;
>     int ret = 0;
> +    bool force_jpeg = false;
> +    bool allow_jpeg = true;
>
>     vnc_framebuffer_update(vs, x, y, w, h, vs->tight.type);

This (ie git master, since this has been committed) doesn't compile
if CONFIG_VNC_JPEG isn't defined:

cam-vm-266:maverick:qemu$ make
  CC    ui/vnc-enc-tight.o
cc1: warnings being treated as errors
ui/vnc-enc-tight.c: In function ‘send_sub_rect’:
ui/vnc-enc-tight.c:1540: error: unused variable ‘allow_jpeg’
ui/vnc-enc-tight.c:1539: error: unused variable ‘force_jpeg’
ui/vnc-enc-tight.c: In function ‘tight_send_framebuffer_update’:
ui/vnc-enc-tight.c:1717: error: ‘tight_jpeg_conf’ undeclared (first
use in this function)
ui/vnc-enc-tight.c:1717: error: (Each undeclared identifier is
reported only once
ui/vnc-enc-tight.c:1717: error: for each function it appears in.)
make: *** [ui/vnc-enc-tight.o] Error 1

-- PMM