[Qemu-devel] Re: [PATCH] simpletrace: Thread-safe tracing

[Paolo Bonzini]

On 02/27/2011 03:58 PM, Stefan Hajnoczi wrote:
> + * Trace records are written out by a dedicated thread.  The thread waits for
> + * records to become available, writes them out, and then waits again.
> + */
> +static pthread_mutex_t trace_lock = PTHREAD_MUTEX_INITIALIZER;
> +static pthread_cond_t trace_available_cond = PTHREAD_COND_INITIALIZER;
> +static pthread_cond_t trace_empty_cond = PTHREAD_COND_INITIALIZER;
> +static bool trace_available;
> +static bool trace_writeout_enabled;

Please use QemuThread.

> +
> +    pthread_attr_init(&attr);
> +    pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
>
> -    tp = find_trace_event_by_name(tname);
> -    if (tp) {
> -        tp->state = tstate;
> -        return true;
> +    sigfillset(&set);
> +    pthread_sigmask(SIG_SETMASK, &set, &oldset);
> +    ret = pthread_create(&thread, &attr, writeout_thread, NULL);
> +    pthread_sigmask(SIG_SETMASK, &oldset, NULL);

This is also taken care of by QemuThread.

Paolo