qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Expre

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers
Date: Sat, 05 Mar 2011 15:59:01 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 
On 03/05/2011 01:34 PM, Peter Maydell wrote:

>>  +        VMSTATE_UINT32(sys_cfgdata, arm_sysctl_state),
>>  +        VMSTATE_UINT32(sys_cfgctrl, arm_sysctl_state),
>>  +        VMSTATE_UINT32(sys_cfgstat, arm_sysctl_state),
>>            VMSTATE_END_OF_LIST()
>>        }

>
>  You need to present the fields as version 2-only.

Can you give an example/explanation? docs/migration.txt doesn't
seem to cover this...


Sure, sorry for being terse. It simply needs to be:

        VMSTATE_UINT32_V(sys_cfgdata, arm_sysctl_state, 2),
        VMSTATE_UINT32_V(sys_cfgctrl, arm_sysctl_state, 2),
        VMSTATE_UINT32_V(sys_cfgstat, arm_sysctl_state, 2),
Also, minimum_version_id needs to remain 1 since you do support loading version 1 saved virtual machines. 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]