[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval'

From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
Date: Sun, 06 Mar 2011 22:18:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110223 Thunderbird/3.1.8

Am 06.03.2011 21:25, schrieb Blue Swirl:
On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<address@hidden>  wrote:
Am 06.03.2011 15:24, schrieb Roy Tam:

2011/3/6 Herve Poussineau<address@hidden>:

[PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
[PATCH 2/3] w32: Add macro timersub to sys/time.h
[PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
Yes, this patch series also addresses the same problem (and one more)
in a better way: it did not add code, but removed a conditional compilation.
(my first try was identical to Herve's patch).
As I replied to those, there are several problems with your approach.
Wrapping timersub() would solve the other problem nicely.

If we'd want to fake a POSIX-like programming environment, there are
other approaches like gnulib. But so far, the approach has been using

Obviously I missed your reply, but I just read it.

Patch 3/3 does not conflict with your intension.

It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]