Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Stefan Weil]

Am 06.03.2011 21:25, schrieb Blue Swirl:
> On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<address@hidden>  wrote:
> > Am 06.03.2011 15:24, schrieb Roy Tam:
> > > Hi,
> > >
> > > 2011/3/6 Herve Poussineau<address@hidden>:
> > >
> > > FYI:
> > > [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
> > > http://www.mail-archive.com/address@hidden/msg56858.html
> > > [PATCH 2/3] w32: Add macro timersub to sys/time.h
> > > http://www.mail-archive.com/address@hidden/msg56859.html
> > > [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
> > > http://www.mail-archive.com/address@hidden/msg56860.html
> > Yes, this patch series also addresses the same problem (and one more)
> > in a better way: it did not add code, but removed a conditional compilation.
> > (my first try was identical to Herve's patch).
> As I replied to those, there are several problems with your approach.
> Wrapping timersub() would solve the other problem nicely.
>
> If we'd want to fake a POSIX-like programming environment, there are
> other approaches like gnulib. But so far, the approach has been using
> wrappers.

Obviously I missed your reply, but I just read it.

Patch 3/3 does not conflict with your intension.

It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.