Re: [Qemu-devel] [PATCH 0/3] tcg: Support debugging leakage of temporaries

[Peter Maydell]

On 7 March 2011 08:42, Aurelien Jarno <address@hidden> wrote:
> On Sun, Mar 06, 2011 at 09:52:56PM +0000, Peter Maydell wrote:
>> In the long term it would be good if we could make the ARM translate.c
>> less brittle like this. Can we at least define a rule for where we're
>> trying to get to so we can move in the right direction for new code?
>>
>> My suggestion would be that we should say that for gen_* functions
>> the callee should always have to free temps passed in as arguments.
>> This matches the convention for tcg_gen_$OP() and gen_helper_$WHATEVER().

> I don't mind whatever convention, but my understanding is that this
> doesn't match tcg_gen_$OP() and gen_helper_$WHATEVER(), which never free
> temps passed in arguments.

Doh. I meant "the caller should always have to free"; sorry for
the confusion.

-- PMM