Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

[Stefan Hajnoczi]

On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <address@hidden> wrote:
> diff --git a/qmp-core.h b/qmp-core.h
> index e3235ec..5ce02f7 100644
> --- a/qmp-core.h
> +++ b/qmp-core.h
> @@ -21,10 +21,65 @@ typedef struct QmpState QmpState;
>  typedef void (QmpCommandFunc)(const QDict *, QObject **, Error **);
>  typedef void (QmpStatefulCommandFunc)(QmpState *qmp__sess, const QDict *, 
> QObject **, Error **);
>
> +typedef struct QmpSlot
> +{
> +    int handle;
> +    void *func;

This should be a void (*func)() pointer for architectures where
function pointers don't fit into void * (e.g. ppc and itanium).

> +QmpSignal *qmp_signal_init(void);
> +void qmp_signal_ref(QmpSignal *obj);
> +void qmp_signal_unref(QmpSignal *obj);
> +int qmp_signal_connect(QmpSignal *obj, void *func, void *opaque);

Same function pointer issue here.

Stefan