qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDr


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState
Date: Mon, 7 Mar 2011 13:52:59 +0000

On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <address@hidden> wrote:
> +static void qmp_chr_send_greeting(QmpSession *s)
> +{
> +    VersionInfo *info;
> +    QObject *vers;
> +    QObject *greeting;
> +    QString *str;
> +
> +    info = qmp_query_version(NULL);
> +    vers = qmp_marshal_type_VersionInfo(info);
> +    qmp_free_version_info(info);
> +
> +    greeting = qobject_from_jsonf("{'QMP': {'version': %p, 'capabilities': 
> []} }",
> +                                  vers);
> +    str = qobject_to_json(greeting);
> +    qobject_decref(greeting);
> +
> +    qemu_chr_write(s->chr, (void *)str->string, str->length);
> +    qemu_chr_write(s->chr, (void *)"\n", 1);
> +    QDECREF(str);
> +}

Is vers leaked?

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]