[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState |
Date: |
Mon, 7 Mar 2011 13:52:59 +0000 |
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <address@hidden> wrote:
> +static void qmp_chr_send_greeting(QmpSession *s)
> +{
> + VersionInfo *info;
> + QObject *vers;
> + QObject *greeting;
> + QString *str;
> +
> + info = qmp_query_version(NULL);
> + vers = qmp_marshal_type_VersionInfo(info);
> + qmp_free_version_info(info);
> +
> + greeting = qobject_from_jsonf("{'QMP': {'version': %p, 'capabilities':
> []} }",
> + vers);
> + str = qobject_to_json(greeting);
> + qobject_decref(greeting);
> +
> + qemu_chr_write(s->chr, (void *)str->string, str->length);
> + qemu_chr_write(s->chr, (void *)"\n", 1);
> + QDECREF(str);
> +}
Is vers leaked?
Stefan
- Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support, (continued)
[Qemu-devel] [PATCH 12/22] qapi: add QAPI module type, Anthony Liguori, 2011/03/06
[Qemu-devel] [PATCH 06/22] qapi: add JSON parsing error message, Anthony Liguori, 2011/03/06
[Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling, Anthony Liguori, 2011/03/06
[Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState, Anthony Liguori, 2011/03/06
- Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState,
Stefan Hajnoczi <=
[Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Anthony Liguori, 2011/03/06
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Stefan Hajnoczi, 2011/03/07
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Anthony Liguori, 2011/03/07
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Avi Kivity, 2011/03/09
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Anthony Liguori, 2011/03/09
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Avi Kivity, 2011/03/09
- Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Anthony Liguori, 2011/03/09
Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command, Avi Kivity, 2011/03/09