[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1
Date: Mon, 7 Mar 2011 15:08:07 +0000

On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <address@hidden> wrote:
> More information about QAPI can be found on the wiki:
> http://wiki.qemu.org/Features/QAPI

Thanks for the good documentation.  A few thoughts:

A "Naming Conventions" section would be a helpful summary of the
different entities that .json schemas describe (events, enums, struct,
functions) and what format their names need to conform to.  It seems
like C identifier rules apply but you also used '-' in names.

The *optional notation for struct fields could also be used for
function arguments instead of using a separate dict there.  I'm
suggesting this for consistency because users currently need to learn
two ways of expressing optional elements.

The signals and slots magic makes sense when looking at the patches,
but I wasn't confident about their semantics just by reading the
documentation.  I had a vague idea about why the Event struct is
needed but didn't fully understand.  Perhaps it's just me but I wanted
to mention it in case you want to polish up that section.

How do async commands work?  You mentioned them when talking about
QAPI but it's not obvious to me that there is any "native" support for
async commands?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]