[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1
Date: Tue, 08 Mar 2011 09:03:45 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/08/2011 08:52 AM, Avi Kivity wrote:
On 03/08/2011 04:38 PM, Anthony Liguori wrote:


Nice.  A couple of remarks.

We may want to use a different way of separating the namespaces - enacapsulation:

  'command': 'guest-command',
   arguments: {
     'command': 'read-file',
     'arguments': {
         'path': '/var/log/messages'

This serves to decouple the two protocols, which may have different support lifetimes (hopefully not).

We could also have a more proper namespace in the protocol.  Like:

{ 'execute': { 'namespace': 'guest', 'command': 'read-file' }, 'arguments': { 'path': '/var/log/messages' } }

I'm not sure I see this as all that critical though. I sort of like the idea of it being transparent to the client whether a guest agent implements a command or QEMU does.

In addition to commands we may also implement a key-value store. A large number of commands may be easy to implement using a single key/value, and it's also easy to live migrate (key/values being stored in but not understood by qemu).

Do you mean the guest querying QEMU for key-values? QMP doesn't have a reverse direction RPC. It only has events which is one of the things that makes live migration work nicely.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]