Re: [Qemu-devel] Re: [PATCH] lsi53c895a: add support for ABORT messages

[Peter Lieven]

Am 09.03.2011 um 10:25 schrieb Bernhard Kohl:

> Am 09.03.2011 09:47, schrieb ext Kevin Wolf:
>> Am 09.03.2011 00:04, schrieb Peter Lieven:
>>> Am 07.10.2010 um 13:27 schrieb Kevin Wolf:
>>> 
>>>> Am 06.09.2010 16:42, schrieb Bernhard Kohl:
>>>>> If these messages are not handled correctly the guest driver may hang.
>>>>> 
>>>>> Always mandatory:
>>>>> - ABORT
>>>>> - BUS DEVICE RESET
>>>>> 
>>>>> Mandatory if tagged queuing is implemented (which disks usually do):
>>>>> - ABORT TAG
>>>>> - CLEAR QUEUE
>>>>> 
>>>>> Signed-off-by: Bernhard Kohl<address@hidden>
>>>> Nicholas, as you seem to have touched the lsi code recently, care to
>>>> review this one? Assuming that you are reasonably familiar with both the
>>>> hardware and the code, you should be quicker than me with this.
>>> Is there a reason why this patch was never added to the stable qemu-kvm 
>>> release?
>>> At least int qemu-kvm-0.14.0 I still can't find it.
>> The reason is that it still didn't get a review.
>> 
> I still depend on this patch. It's needed for our legacy guest OS.
> It's heavily in use here with STGT iSCSI disks via scsi-generic.

We use it in qemu-0.12.5 as well for a very long time. I saw an assertion last 
year
with errors of unimplemented abort feature preceding. Since we use this patch
we have never seen it again.

Peter

> 
> Bernhard