Re: [Qemu-devel] [PATCH 19/22] qapi: add QMP put-event command

[Avi Kivity]

On 03/07/2011 03:23 AM, Anthony Liguori wrote:
> This is needed for libqmp to support events.  put-event is used to disconnect
> from signals.
>
> Signed-off-by: Anthony Liguori<address@hidden>
>
> diff --git a/qmp-schema.json b/qmp-schema.json
> index 3f2dd4e..a13885f 100644
> --- a/qmp-schema.json
> +++ b/qmp-schema.json
> @@ -58,3 +58,18 @@
>   # Since: 0.14.0
>   ##
>   [ 'qmp_capabilities', {}, {}, 'none' ]
> +
> +##
> +# @put_event:
> +#
> +# Disconnect a signal.  This command is used to disconnect from a signal based
> +# on the handle returned by a signal accessor.
> +#
> +# @tag: the handle returned by a signal accessor.
> +#
> +# Returns: Nothing on success.
> +#          If @tag is not a valid handle, InvalidParameterValue
> +#
> +# Since: 0.15.0
> +##
> +[ 'put-event', {'tag': 'int'}, {}, 'none' ]

Why is tag an int?  don't we use strings for command ids and similar?

Also could be better named, disconnect-event or unlisten-event.

--
error compiling committee.c: too many arguments to function