[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command
Date: Wed, 09 Mar 2011 08:13:27 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/09/2011 07:51 AM, Avi Kivity wrote:
On 03/09/2011 03:44 PM, Anthony Liguori wrote:
Yeah, it's only loosely JSON as I don't use a JSON parser.

Goes kind of against all the buzzwords you're letting fly here...

The schema defines arguments in a dictionary because in QMP, the argument order doesn't matter. But the argument order matters in C so I need to use a custom parser to preserve dictionary order.

We could extend our parser to annotate the dictionary with the original order. Not worth it though.

There's no way to do commenting in JSON and I really wanted to have inline documentation.

But otherwise, it's valid JSON.

We should then have a transformation that generates a valid json for clients to use. We could even include the documentation as a 'doc': key.

Yes, as I mentioned on the call, that's my plan for 0.15. I hadn't thought about the doc bit though.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]