[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pxa2xx_timer: separate irq for pxa27x handl
Re: [Qemu-devel] [PATCH 1/2] pxa2xx_timer: separate irq for pxa27x handling
Thu, 10 Mar 2011 05:35:24 +0100
On 4 March 2011 01:40, Dmitry Eremin-Solenikov <address@hidden> wrote:
> First, sysbus_init_irq shan't be called on on-stack variables. Indeed,
> it only stores a passed pointer in qdev and the stored irq is later
> populated, so we get a nice write-to-stack bug.
> Second, irq for pxa27x should probably be handled in a more gentler way,
> as we should check if we have events to raise this irq.
Thanks, pushed this patch and sorry for breaking the code. In the
second patch I decided against splitting the device initialisation
between pxa2xx_pic_init and pxa2xx_pic_initfn for clarity, it seems
the round way and just makes the code more tricky.
I also pushed the mainstone PCMCIA changes.