[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH v2] Make VNC support optional

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH v2] Make VNC support optional
Date: Fri, 11 Mar 2011 09:50:03 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/11/2011 09:11 AM, Peter Maydell wrote:
On 11 March 2011 14:55, Anthony Liguori<address@hidden>  wrote:
On 03/11/2011 08:54 AM, Jes Sorensen wrote:
On 03/11/11 15:39, Anthony Liguori wrote:
So what ends up being the default display if VNC and SDL are both
disabled?  Have you tested this?
Then you cry :) actually you just don't get video output, a bit like if
you run with -nographic, except it doesn't try to force taking over
stdio. This is intentional btw :)
Hrm, that doesn't sound very safe to me.  Forcing -nographic would be better
Personally I'd rather -nographic didn't take over stdio either:
it should just disable graphics, and if you want serial on your
stdio you can say "-serial stdio"; it's a bit non-orthogonal
for an option which is about how we handle video output to have
a non-overridable side-effect of redirecting the serial port.

(Also the "-nographic" running of serial over stdio doesn't let
you kill qemu with ^C, the way "-serial stdio" does, which is
just annoyingly inconsistent...)

So if we want to have another mode that has different characteristics, that's fine, but it should be selectable via the command line regardless of how the build is configured.

I don't like the idea of a magic mode that is unlocked when other features are disabled because then there's no good way to test such a feature in a full build.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]