[Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec

[Marcelo Tosatti]

On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote:
> >> @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env)
> >>              abort();
> >>          }
> >>  
> >> -        ret = 0; /* exit loop */
> >>          switch (run->exit_reason) {
> > 
> > Better keep ret assignment here so default behaviour is to 
> > exit loop? EXCP_INTERRUPT.
> 
> There is no real default behavior: in two cases we stay in the loop, in
> two others we leave, and the rest obtains ret from a return value.
> Moreover, if a new case misses to set ret, the compiler will complain.
> 
> Jan

It will not complain because "ret" is used to store return value
of KVM_RUN.