Re: [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid

[Stefan Hajnoczi]

On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V
<address@hidden> wrote:
> +static int get_dotl_openflags(int oflags)
> +{
> +    int flags;
> +    /*
> +     * Since we can share the fd between multiple fids,
> +     * open the file in read write mode
> +     */

I didn't know that fds are shared between fids.  Also this code does
not always open O_RDWR.  This comment is incorrect (perhaps a later
patch changes assumptions, I haven't looked yet, but introducing
temporary inconsistencies makes it difficult to review and potentially
confusing for git-bisect users).

Stefan