Re: [Qemu-devel] [PATCH 2/7] introduce libcacard/vscard_common.h

[Jes Sorensen]

On 02/23/11 12:20, Alon Levy wrote:
> diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h
> new file mode 100644
> index 0000000..7449314
> --- /dev/null
> +++ b/libcacard/vscard_common.h
> @@ -0,0 +1,167 @@
> +/* Virtual Smart Card protocol definition
> + *
> + * This protocol is between a host using virtual smart card readers,
> + * and a client providing the smart cards, perhaps by emulating them or by
> + * access to real cards.
> + *
> + * Definitions for this protocol:
> + *  Host   - user of the card
> + *  Client - owner of the card
> + *
> + * The current implementation passes the raw APDU's from 7816 and 
> additionally
> + * contains messages to setup and teardown readers, handle insertion and
> + * removal of cards, negotiate the protocol via capabilities and provide
> + * for error responses.
> + *
> + * Copyright (c) 2011 Red Hat.
> + *
> + * This code is licensed under the LGPL.

Please be more specific on the license. Other code has the following:
 * This work is licensed under the terms of the GNU LGPL, version 2.1 or
later.
 * See the COPYING.LIB file in the top-level directory.

[snip]
> +/* VSCMsgInit               Client <-> Host
> + * Client sends it on connection, with its own capabilities.
> + * Host replies with VSCMsgInit filling in its capabilities.
> + *
> + * It is not meant to be used for negotiation, i.e. sending more then
> + * once from any side, but could be used for that in the future.
> + * */

Looks like some automatic mangling of comments - happens in more than
one place.

Except for the cosmetic stuff, looks ok.

Jes