Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

[Anthony Liguori]

On 03/14/2011 09:07 AM, Daniel P. Berrange wrote:
> On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote:
> > On 02/23/11 12:20, Alon Levy wrote:
> > > diff --git a/configure b/configure
> > > index 791b71d..147aab3 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -174,6 +174,7 @@ trace_backend="nop"
> > >   trace_file="trace"
> > >   spice=""
> > >   rbd=""
> > > +smartcard="yes"
> > IMHO smartcard support shouldn't be enabled per default. The userbase is
> > limited.
> Deciding based on importance/size of userbase is rather subjective.
> IMHO all features should be enabled by default, but if they depend
> on a 3rd party library that isn't installed on the build host, they
> should automatically disable themselves. eg

Yes, and this is the policy we've taken pretty consistently in QEMU.

Features that aren't enabled by default are subject to bit-rot.

Regards,

Anthony Liguori

>   * [the default]       - on, if external library is present, off otherwise
>   * --enable-<feature>   - always on, raise error if external library is missing
>   * --disable-<feature>  - always off,
>
> Regards,
> Daniel