[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7] ccid: configure: improve --enable-smartcard

From: Jes Sorensen
Subject: Re: [Qemu-devel] [PATCH 7/7] ccid: configure: improve --enable-smartcard flags
Date: Mon, 14 Mar 2011 16:44:26 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7

On 02/23/11 12:20, Alon Levy wrote:
>  * add --enable-smartcard and --disable-smartcard flags
>  * let the nss check only disable building the ccid-card-emulated device
>  * report only if nss is found or not, not smartcard build inclusion
>  * don't link with NSS if --disable-smartcard-nss

The --disable-smartcard flag really should go with the initial smartcard
changes to configure. That way it is possible to test that each
individual patch doesn't break the build when smartcard support is
enabled or disabled. If you add it at the end, you figuring out which
patch is the problem is much harder.

Adding the smartcard-nss flag should go next to the patch that adds the
code relying on the flag.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]