[Qemu-devel] Re: [v1 PATCH 1/3]: Move the paio_signal_handler to a generic location.

[Stefan Hajnoczi]

On Tue, Mar 15, 2011 at 10:36 AM, Arun R Bharadwaj
<address@hidden> wrote:
> * Arun R Bharadwaj <address@hidden> [2011-03-15 16:04:53]:
>
> Author: Arun R Bharadwaj <address@hidden>
> Date:   Thu Mar 10 14:45:25 2011 +0530
>
>    Move the paio_signal_handler to a generic location.
>
>    The paio subsystem uses the signal, SIGUSR2. So move
>    the signal handler to a more generic place such that
>    other subsystems like 9pfs can also use it.
>
>    TODO: I have moved the signal handler code to
>    qemu-thread.c, which is NOT the right place. I need
>    suggestions as to where is the right place to put it.

I think os-posix.c would be appropriate.  Please check how this
affects Windows host and linux-user builds.

> @@ -356,6 +359,15 @@ static void *aio_thread(void *unused)
>         idle_threads++;
>         mutex_unlock(&lock);
>
> +        if (posix_aio_state) {

If we get here posix_aio_state must be non-NULL.  Please remove the check.

> +void sigusr2_signal_handler(int signum)

static void sigusr2_signal_handler(int signum)

Stefan