[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

[Jes Sorensen]

On 03/15/11 15:51, Anthony Liguori wrote:
>> +            } else if (strstart(opts, ",window_close=",&nextopt)) {
>> +                opts = nextopt;
>> +                if (strstart(opts, "on",&nextopt)) {
>> +                    no_quit = 0;
>> +                } else if (strstart(opts, "off",&nextopt)) {
>> +                    no_quit = 1;
>> +                } else {
>> +                    goto invalid_display;
>> +                }
>> +            } else {
>> +                goto invalid_display;
>> +            }
>> +            opts = nextopt;
>> +        }
> 
> So the natural reaction here is going to be, "just use QemuOpts".  But
> this is harder than it seems.  The problem is that the VNC options
> inverse the meaning of booleans making conversion of VNC to use QemuOpts
> much harder than it would appear.
> 
> Doing it this way lets us pass the vnc option string directly to
> vnc_display_open().  I don't like it much, but I don't mind it as an
> interim step.

Yeah, it isn't particularly pretty, but it really requires we rewamp the
arguments completely which I think is out of scope for the initial
change here.

Cheers,
Jes