[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

[Peter Maydell]

On 16 March 2011 11:00,  <address@hidden> wrote:
> From: Jes Sorensen <address@hidden>
>
> This patch introduces a -display argument which consolidates the
> setting of the display mode. Valid options are:
> sdl/curses/default/serial (serial is equivalent to -nographic)

You forgot to update the commit message when you took out 'serial'...

Some minor nitpicking about docs wording follows (I know this text
is just copied from the -sdl/-curses options, but since we're here...)

> +DEF("display", HAS_ARG, QEMU_OPTION_display,
> +    "-display sdl[,frame=on|off][,alt_grab=on|off][,ctrl_grab=on|off]\n"
> +    "            [,window_close=on|off]|curses\n"
> +    "                select display type\n", QEMU_ARCH_ALL)
> +STEXI
> address@hidden -display @var{type}
> address@hidden -display
> +Select type of display to use. This option is a replacement for the
> +old style -sdl/-curses/... options. Valid values for @var{type} are
> address@hidden @option
> address@hidden sdl
> +Pick the SDL display option.

How about "Display video output via SDL (usually in a separate graphics
window; see the SDL documentation for other possibilities)." ?

> address@hidden curses
> +Pick the curses display option. Normally, QEMU uses SDL to display the
> +VGA output.  With this option, QEMU can display the VGA output when in
> +text mode using a curses/ncurses interface.  Nothing is displayed in
> +graphical mode.
> address@hidden table
> +ETEXI

This kind of implies that the only kind of video is VGA, which isn't
true.

"Display video output via curses. For graphics device models which
support a text mode, QEMU can display this output using a curses/ncurses
interface. Nothing is displayed when the graphics device is in
graphical mode or if the graphics device does not support a text mode.
Generally only the VGA device models support text mode."

?

-- PMM