[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)
Date: Wed, 16 Mar 2011 13:06:54 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/16/2011 11:31 AM, Paolo Bonzini wrote:
On 03/16/2011 05:03 PM, Anthony Liguori wrote:
So for an event, you just need to do:

{ 'signal': 'vnc-connected', 'data': { 'client': 'VncClientInfo' } }

And you can add new fields to the VncClientInfo structure as much as
you'd like without worrying about breaking the C ABI.

So why couldn't you automatically wrap the events data field in a structure (e.g. vnc-connected events receive a VncConnectedEventData*)?

You could, but is it really necessary or even useful?

I don't see signals as being any different than function calls. You could do the same thing for function calls.

A good example is the vnc-connected event. I didn't post the full event, it's reall:

{ ' signal': 'vnc-connected', 'data': { 'client': 'VncClientInfo', 'server': 'VncServerInfo' } }

You could add an automatic structure around these two members but that makes the C interface quite a bit more awkward for no obvious gain.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]