[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replac
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe |
|
Date: |
Thu, 17 Mar 2011 11:29:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 03/17/11 11:27, Alon Levy wrote:
> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote:
>>> Same for the asserts below, writes are from spice server thread, reads
>>> are in iothread.
>>
>> But shouldn't this make it try to reconnect? Even if the reconnect
>> fails, it shouldn't kill the guest IMHO.
>
> reconnect? between two threads in the qemu process? why would the write
> fail to begin with? this is like saying if I'm failing a kvm ioctl I should
> just retry.
Ah ok, I missed that part, somehow I had in my mind it was two different
processes, despite you mentioning threads.
Still if gfx handling fails, it shouldn't nuke the guest.
Cheers,
Jes
- [Qemu-devel] [PATCH v3 2/4] qxl: implement get_command in vga mode without locks, (continued)
- [Qemu-devel] [PATCH v3 2/4] qxl: implement get_command in vga mode without locks, Alon Levy, 2011/03/16
- [Qemu-devel] [PATCH v3 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher, Alon Levy, 2011/03/16
- [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Alon Levy, 2011/03/16
- [Qemu-devel] Re: [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Hans de Goede, 2011/03/16
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Jes Sorensen, 2011/03/16
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Alon Levy, 2011/03/17
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Jes Sorensen, 2011/03/17
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Alon Levy, 2011/03/17
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Alon Levy, 2011/03/17
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Jes Sorensen, 2011/03/17
- Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe, Alon Levy, 2011/03/17