[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other use
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug |
Date: |
Mon, 21 Mar 2011 18:39:21 +0530 |
After a hot-unplug operation, the previous behaviour was to close the
chardev. That meant the chardev couldn't be re-used. Also, since
chardev hot-plug isn't possible so far, this means virtio-console
hot-plug isn't feasible as well.
With this change, the chardev is kept around. A new virtio-console
channel can then be hot-plugged with the same chardev and things will
continue to work.
Signed-off-by: Amit Shah <address@hidden>
---
hw/virtio-console.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index be59558..6b5237b 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -82,7 +82,11 @@ static int virtconsole_exitfn(VirtIOSerialPort *port)
VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
if (vcon->chr) {
- qemu_chr_close(vcon->chr);
+ /*
+ * Instead of closing the chardev, free it so it can be used
+ * for other purposes.
+ */
+ qemu_chr_add_handlers(vcon->chr, NULL, NULL, NULL, NULL);
}
return 0;
--
1.7.4
- [Qemu-devel] [PULL #7 0/7] virtio-serial fixes, enhancements, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 1/7] virtio-serial: Use a struct to pass config information from proxy, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 3/7] virtio-serial: Enable ioeventfd, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 4/7] virtio-serial-bus: Simplify handle_output() function, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear ->have_data() pointer after unplug, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug,
Amit Shah <=
- [Qemu-devel] [PATCH 7/7] char: Prevent multiple devices opening same chardev, Amit Shah, 2011/03/21
- [Qemu-devel] Re: [PULL #7 0/7] virtio-serial fixes, enhancements, Juan Quintela, 2011/03/23