[Qemu-devel] Re: [PATCH 1/3] alleviate time drift with HPET periodic timers

[Ulrich Obergfell]

>> Part 1 of the patch implements the following QEMU command line option.
>>
>> -hpet [device=none|present][,driftfix=none|slew]
> 
> Just define driftfix as property of the hpet device. That way it can be
> controlled both globally (-global hpet.driftfix=...) and per hpet block
> (once we support instantiating >1 of them).


Many Thanks Jan,

I started investigating code changes. I'm thinking of ...

- adding a new field to the HPETState structure.

    uint32_t driftfix;

- adding the property 'driftfix' to the DeviceInfo structure.

    DEFINE_PROP_BIT("driftfix", HPETState, driftfix, 0, false)

  Using a single bit so that the option syntax would be, e.g.:

    -global hpet.driftfix=on     (Default is 'off')

- Replace all 'if (hpet_driftfix ...)' by:

    if ((HPETState)s->driftfix ...)


Regards,

Uli