Re: [Qemu-devel] [PATCH] cocoa: do not create a spurious window for -version

[Andreas Färber]

Am 21.03.2011 um 09:30 schrieb Tristan Gingold:

> On Mar 19, 2011, at 2:44 PM, Andreas Färber wrote:
>
> > Am 15.03.2011 um 14:18 schrieb Tristan Gingold:
> >
> > > When invoked with -version, qemu will exit just after displaying  
> > > the version,
> > > so there is no need to create a window.
> > > Also handles --XXX options.
> > >
> > > Signed-off-by: Tristan Gingold <address@hidden>
> >
> > Looks good to me except for the qemu_main() indentation.

My apologies, that was for one thing my mailer, and my original  
indentation had an extra four spaces indentation for readability that  
we're now eating up. No changes necessary from my side then.

Applied to my Cocoa branch for cherry-picking / pulling:

git://repo.or.cz/qemu/afaerber.git cocoa-for-upstream


Note that we still have the same issue with '-cpu ?' and others. Same  
for errors such as specifying too much RAM for a machine. I was  
definitely not planning to handle all of those here.

The path I wanted to take instead would be to redefine hw_error() etc.  
as macros that display the message in a window-modal sheet rather than  
postponing the window creation for all potential error cases. Patches  
welcome. :)

Andreas