[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState
Date: Wed, 23 Mar 2011 10:22:24 +0000

On 23 March 2011 00:16, Anthony Liguori <address@hidden> wrote:
> +    if (old_version != new_version) {
> +        g_error("Version %d of device `%s' is available in QEMU, but schema 
> still reports %d, please update schema.\n",
> +                new_version, device, old_version);
> +    }

Might be nice for these "please update" error messages to
include a pointer to a docs file explaining in more detail
how to do that?
(also >80 char line ;-))

> diff --git a/vmstate/schema.json b/vmstate/schema.json
> new file mode 100644
> index 0000000..23483ab
> --- /dev/null
> +++ b/vmstate/schema.json
> @@ -0,0 +1,1176 @@
> +{
> +    "cpu": {
> +        "mcg_cap": "uint64",
> +        "a20_mask": "int32",
> +        "tsc_offset": "uint64",

This schema file appears to be board-specific (or at least
x86-specific) -- shouldn't the cpu/board/whatever name
be in the filename, so we have scope to expand the test
to checking migration issues for other platforms too?

(I don't care much about ARM migration breakages just at the
moment but I suspect that it will be becoming more important
by this time next year...)

Also since this looks like an autogenerated file that's going
to be going into version control maybe it should have a
comment header at the top of the "autogenerated, do not edit
by hand!" type.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]