[Qemu-devel] Re: [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

[Juan Quintela]

Peter Maydell <address@hidden> wrote:
> On 23 March 2011 14:19, Juan Quintela <address@hidden> wrote:
>> Peter Maydell <address@hidden> wrote:
>> ARM people are sending lots of vmstate changes, I guess/hope that
>> somebody is trying to get it working.
>>
>> /me looks at Peter O:-), hint, hint, ...
>
> Well, the main thing I care about currently (or did back before
> Christmas which is when I sent a patchset to add save/restore
> to a pile of ARM devices) is simple save-and-restore for debugging
> use. The rest is just that patches don't get through code review
> unless they get the vmstate stuff right, and I care about not
> being rejected :-)
>
> I think it's still the case that there are devices in
> some of the ARM devboards with no save/restore support
> at all. I would really prefer it if the default for a
> device was "I do not support this" with the things like
> USB where somebody has audited them as genuinely needing
> no save/restore code explicitly marked as "this is OK";
> then we could easily determine what needed fixing and
> not offer a broken facility to users.

I agree, but that means (again), review of all devices to change the
defaults.  It is on my ToDo list (but my ToDo list is huge :-(

>> Any idea if there are images for testing ARM?
>
> There are prebuilt images on Aurelien's website for
> ARM and others, which is the simplest thing:
> http://www.aurel32.net/info/debian_arm_qemu.php

That images don't migrate for me at all.  Guest got hung after
migration, at least some state (probably irq's) are not passed
correctly.

Later, Juan.