Re: [Qemu-devel] [PATCH 05/17] s390x: enable CPU_QuadU

[Peter Maydell]

On 24 March 2011 15:58, Alexander Graf <address@hidden> wrote:
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -138,7 +138,7 @@ typedef union {
>     uint64_t ll;
>  } CPU_DoubleU;
>
> -#ifdef TARGET_SPARC
> +#if defined(TARGET_SPARC) || defined(TARGET_S390X)
>  typedef union {
>     float128 q;
>  #if defined(HOST_WORDS_BIGENDIAN) \

I think this typedef should just be protected by
#ifdef CONFIG_SOFTFLOAT (because only softfloat defines
a float128 type) rather than by a set of TARGET_* checks.

If you do that then you can get rid of the "|| (defined(__arm__)
&& !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT))" part
of the inner ifdef, beacuse it's always false.

-- PMM