[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] severe memory leak caused by broken palette_

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2] severe memory leak caused by broken palette_destroy() function
Date: Fri, 25 Mar 2011 07:36:43 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/25/2011 04:31 AM, Stefan Hajnoczi wrote:
On Fri, Mar 25, 2011 at 8:45 AM, Ulrich Obergfell<address@hidden>  wrote:
This is version 2 of the patch that I originally posted in:


[Sorry, I missed to include the keyword 'PATCH' in the subject
  of the original post.]

The following commit breaks the code of the function palette_destroy().


The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:

     70 void palette_destroy(VncPalette *palette)
     71 {
     72     if (palette == NULL) {
     73         qemu_free(palette);
     74     }
     75 }

Version 2 of the patch calls qemu_free() unconditionally.

Signed-off-by: Ulrich Obergfell<address@hidden>
Looks good.

Applied.  Thanks.


Anthony Liguori

Reviewed-by: Stefan Hajnoczi<address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]