[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V2 PATCH] floppy: save and restore DIR register

From: Jes Sorensen
Subject: Re: [Qemu-devel] [V2 PATCH] floppy: save and restore DIR register
Date: Mon, 28 Mar 2011 10:16:54 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9

On 03/28/11 04:47, Jason Wang wrote:
> We need to keep DIR register unchanged across migration, but currently it
> depends on the media_changed flags from block layer. Since we do not
> save/restore it and the bdrv_open() called in dest node may set the
> media_changed flag when trying to open floppy image, guest driver may think 
> the
> floppy have changed after migration. To fix this, a new filed media_changed in
> FDrive strcutre was introduced in order to save and restore the it from block
> layer through pre_save/post_load callbacks.
> Signed-off-by: Jason Wang <address@hidden>
> ---
>  hw/fdc.c |   52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 51 insertions(+), 1 deletions(-)

Looks good to me.

Reviewed-by: Jes Sorensen <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]