[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset
Date: Mon, 28 Mar 2011 11:21:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Isaku Yamahata <address@hidden> writes:

> On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote:
>> Am 28.03.2011 04:17, schrieb Isaku Yamahata:
>>> On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote:
>>>> cirrus_reset is also called by the pci framework,
>>>> so there is no need to call it in cirrus_init_common.
>>>> Cc: Michael S. Tsirkin<address@hidden>
>>>> Signed-off-by: Stefan Weil<address@hidden>
>> I tested the new code with isa pc, too. In gdb, I could see that it also  
>> calls
>> cirrus_reset twice. But isa pc is broken since the switch to sea bios, so
>> obviously isa is an unmaintained part of qemu. Even with bochs bios,
>> it no longer works, so it is broken at least twice.
> Ah, I see. The the second reset is called not via pci reset framework,
> but qemu reset framework. So removing the above reset call makes sense.
> It would be another patch to make use of pci reset framework.

Then the proposed commit message's claim cirrus_reset() is "called by
the pci framework" is incorrect, isn't it?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]