[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

From: Alon Levy
Subject: Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus
Date: Mon, 28 Mar 2011 14:13:16 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote:
> On 03/23/11 14:19, Alon Levy wrote:
> > A CCID device is a smart card reader. It is a USB device, defined at [1].
> > This patch introduces the usb-ccid device that is a ccid bus. Next patches 
> > will
> > introduce two card types to use it, a passthru card and an emulated card.
> > 
> >  [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110.
> > 
> > Signed-off-by: Alon Levy <address@hidden>
> This looks ok to me now - I noticed that the comments in the header file
> refers to u8/u16/u32 for types, even though the code uses
> uint{8,16,32}_t, but I don't think that warrants a fix.
> If the comment goes in, please fix the spelling of my name.

Gah, I'm terribly sorry, I usually try to be correct on that point.

> Reviewed-by: Jes Sorensen <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]