[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use c

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status
Date: Mon, 28 Mar 2011 15:15:08 +0100

On 14 March 2011 05:35, Nathan Froyd <address@hidden> wrote:
> On Fri, Mar 11, 2011 at 10:31:31PM +0000, Peter Maydell wrote:
>> On 11 March 2011 18:30, Nathan Froyd <address@hidden> wrote:
>> > Is there a reason that you don't simply use the global env rather than
>> > passing in an extra parameter everywhere?
>> Just following the pattern that generally seems to be used by
>> most helper functions, ie if you want the CPU env pass it in
>> as a parameter. As far as I know, you can't use the global
>> env unless you're in op_helper.c because that's the only
>> source file compiled with the right flags.
> Oh, right.  I am ambivalent as to whether passing env to such functions
> is the right thing to do or not.

So did this amount to a request for a change to this patchset,
or are you happy to let it pass?

(I'm planning to stick this patchset into a pull-request with some
of the other ARM patches that have had a few weeks for review comment
later this week, so if you'd like a change now would be a good time
to say so...)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]