[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors |
Date: |
Tue, 29 Mar 2011 16:03:19 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Mon) 28 Mar 2011 [23:14:16], Michael S. Tsirkin wrote:
> When guest does something illegal, such as
> programming invalid index values in the virtio
> device, qemu currently tends to crash.
>
> With virtio, a better idea is to log an error,
> and set status to FAIL which stops the device.
>
> Add an API to do this, and fix core, blk and serial
> to use it on error.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/virtio-blk.c | 12 +++++--
> hw/virtio-serial-bus.c | 13 +++++--
> hw/virtio.c | 79
> +++++++++++++++++++++++++++++++-----------------
> hw/virtio.h | 7 +++-
> 4 files changed, 73 insertions(+), 38 deletions(-)
ACK
Amit