[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] exit if -drive specified is invalid instead of igno

From: Michael Tokarev
Subject: [Qemu-devel] [PATCH] exit if -drive specified is invalid instead of ignoring the "wrong" -drive
Date: Wed, 30 Mar 2011 16:31:05 +0400

This fixes the problem when qemu continues even if -drive specification
is somehow invalid, resulting in a mess.  Applicable for both current
master and for stable-0.14 (and the same issue exist 0.13 and 0.12 too).

The prob can actually be seriuos: when you start guest with two drives
and make an error in the specification of one of them, and the guest
has something like a raid array on the two drives, guest may start failing
that array or kick "missing" drives which may result in a mess - this is
what actually happened to me, I did't want a resync at all, and a resync
resulted in re-writing (and allocating) a 4TB virtual drive I used for
testing, which in turn resulted in my filesystem filling up and whole
thing failing badly.  Yes it was just testing VM, I experimented with
larger raid arrays, but the end result was quite, well, unexpected.

Signed-off-by: Michael Tokarev <address@hidden>
 vl.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/vl.c b/vl.c
index 8bcf2ae..3792afb 100644
--- a/vl.c
+++ b/vl.c
@@ -2098,7 +2098,9 @@ int main(int argc, char **argv, char **envp)
             case QEMU_OPTION_drive:
-                drive_def(optarg);
+                if (drive_def(optarg) == NULL) {
+                    exit(1);
+                }
             case QEMU_OPTION_set:
                 if (qemu_set_option(optarg) != 0)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]