Re: [Qemu-devel] [PATCH] Don't limit node count by smp count

[Sasha Levin]

On Wed, 2011-03-30 at 14:28 -0500, Anthony Liguori wrote:
> On 03/30/2011 02:14 PM, Sasha Levin wrote:
> > It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> > limited by amount of CPUs.
> 
> But does this actually work in the code today and does it work with any 
> guests?
> 

I've tested it on an Ubuntu desktop as a guest and it worked
fine, /sys/devices/system/node/has_cpu was as expected.

> Regards,
> 
> Anthony Liguori
> 
> > Signed-off-by: Sasha Levin<address@hidden>
> > ---
> >   vl.c |    4 ++--
> >   1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index 8bcf2ae..8cc1aa8 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -3002,8 +3002,8 @@ int main(int argc, char **argv, char **envp)
> >       if (nb_numa_nodes>  0) {
> >           int i;
> >
> > -        if (nb_numa_nodes>  smp_cpus) {
> > -            nb_numa_nodes = smp_cpus;
> > +        if (nb_numa_nodes>  MAX_NODES) {
> > +            nb_numa_nodes = MAX_NODES;
> >           }
> >
> >           /* If no memory size if given for any node, assume the default
> > case
> >
> >
> 

-- 

Sasha.